New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for more mistakes in translatable strings #64

Merged
merged 12 commits into from Aug 6, 2018

Conversation

2 participants
@swissspidy
Collaborator

swissspidy commented Jul 31, 2018

See #61.

swissspidy added some commits Jul 31, 2018

swissspidy added some commits Jul 31, 2018

@swissspidy swissspidy changed the title from [WIP] Check for more mistakes in translatable strings to Check for more mistakes in translatable strings Aug 3, 2018

@swissspidy swissspidy requested a review from wp-cli/committers Aug 3, 2018

swissspidy added some commits Aug 5, 2018

@swissspidy swissspidy requested a review from schlessera Aug 5, 2018

Show outdated Hide outdated features/makepot.feature
Show outdated Hide outdated src/MakePotCommand.php
Show outdated Hide outdated src/MakePotCommand.php

@swissspidy swissspidy requested a review from schlessera Aug 5, 2018

swissspidy added some commits Aug 6, 2018

@swissspidy

This comment has been minimized.

Show comment
Hide comment
@swissspidy

swissspidy Aug 6, 2018

Collaborator

I think this one is good to go (pending passing tests and final review).

Nice side effect when this is in master:

I can use #69 to create a WordPress Trac ticket to improve all the strings in WordPress core that get flagged by this command.

Collaborator

swissspidy commented Aug 6, 2018

I think this one is good to go (pending passing tests and final review).

Nice side effect when this is in master:

I can use #69 to create a WordPress Trac ticket to improve all the strings in WordPress core that get flagged by this command.

@schlessera schlessera added this to the 0.1.0 milestone Aug 6, 2018

@schlessera schlessera merged commit 7762b19 into master Aug 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the 61-audit branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment