New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing an empty file comment #82

Merged
merged 2 commits into from Sep 14, 2018

Conversation

2 participants
@swissspidy
Copy link
Collaborator

swissspidy commented Sep 13, 2018

Related: ampproject/amp-wp#1416.

This change allows omitting the file comment at the top of the POT file to prevent issues with the pot-to-php script that Gutenberg and other plugins use.

Show resolved Hide resolved features/makepot.feature Outdated

@swissspidy swissspidy requested a review from schlessera Sep 14, 2018

@schlessera schlessera added this to the 2.0.2 milestone Sep 14, 2018

@schlessera schlessera merged commit cc7c24f into master Sep 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the empty-file-comment branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment