New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test cases for include/exclude options #83

Merged
merged 2 commits into from Oct 25, 2018

Conversation

3 participants
@yousan
Copy link
Contributor

yousan commented Sep 14, 2018

Add unit test cases for include/exclude options.
This would replace functional tests (behat).

(Really thank you @swissspidy 馃槃
(I was helped at WordCamp Tokyo 2018 Contributor day

refs #70

@yousan

This comment has been minimized.

Copy link
Contributor

yousan commented Sep 14, 2018

fails...

@schlessera schlessera modified the milestone: 2.0.2 Sep 18, 2018

@swissspidy swissspidy requested a review from schlessera Oct 25, 2018

@swissspidy
Copy link
Collaborator

swissspidy left a comment

As mentioned in #85, I think we should just merge this and then fix the order of exclude/include as mentioned in #84.

@schlessera schlessera added this to the 2.0.2 milestone Oct 25, 2018

@schlessera schlessera merged commit e7d3a72 into wp-cli:master Oct 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@swissspidy

This comment has been minimized.

Copy link
Collaborator

swissspidy commented Oct 25, 2018

@yousan Sorry it took me so long to go through this, but thanks again for your contribution!

@yousan yousan deleted the yousan:unittest-for-include-exclude-options branch Oct 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment