Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Support parsing minified JS files created by WebPack #85
In order to resolve https://meta.trac.wordpress.org/ticket/3875
Because WebPack wraps calls to
This part will likely later need to be expanded to support more forms in which translations may be called.
left a comment
I'd like to see 2 changes before merging this:
@schlessera Thanks for the review!
I've added tests to makepot.feature. These are currently simply added to existing JS parsing test as especially following
The WebPack specific format (
The added tests fail when I revert the changes to
Resolving the callee has also been split to it's own function with more extensive documentation and examples.
Instead of parsing
For this we'd need to swap the include and exclude check as discussed in #84. I'm gonna try to merge the unit tests for that (#70) and then attempt modifying
referenced this pull request
Oct 25, 2018
Using this PR and I can't get the JS strings of the current 5.0 branch (
Am I missing something?