New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include should override exclude instead of the other way around #87

Merged
merged 3 commits into from Oct 25, 2018

Conversation

2 participants
@swissspidy
Copy link
Collaborator

swissspidy commented Oct 25, 2018

This is still a WIP as some Behat tests are failing.

Any help appreciated as I might be able to work on it again until Saturday.

Fixes #84.
See also #85.

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Oct 25, 2018

The issue seems to be that you're using absolute paths in some places, instead of root-relative paths.

The vendor folder therefore gets pulled in (instead of being excluded) because the include foo matches <absolute path>/foo-plugin/vendor.

I'll look at adapting the code.

schlessera added some commits Oct 25, 2018

@schlessera schlessera merged commit 0a485e9 into master Oct 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@delete-merged-branch delete-merged-branch bot deleted the exclude-include-exclude-include branch Oct 25, 2018

@schlessera schlessera added this to the 2.0.2 milestone Oct 25, 2018

@swissspidy

This comment has been minimized.

Copy link
Collaborator

swissspidy commented Oct 25, 2018

Thanks a lot for your help @schlessera!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment