New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace regexes Peast can't parse #99

Merged
merged 4 commits into from Oct 29, 2018

Conversation

2 participants
@herregroen
Copy link
Contributor

herregroen commented Oct 29, 2018

Fixes #98.

Currently only covers the simple /"/ use-case which is the only one we're encountering right now.

Could be updated to use a regex to cover more complex scenarios but I'd prefer to avoid that. Should ideally be fixed in mck89/peast#3.

Show resolved Hide resolved features/makepot.feature Outdated
Show resolved Hide resolved src/JsFunctionsScanner.php Outdated

@schlessera schlessera added this to the 2.0.2 milestone Oct 29, 2018

Clarify comment.
Co-Authored-By: herregroen <herregroen@gmail.com>

@schlessera schlessera merged commit 70509a4 into wp-cli:master Oct 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera changed the title Replace regexes Peast can't parse. Replace regexes Peast can't parse Oct 29, 2018

@herregroen herregroen deleted the herregroen:escape-quote-regexes branch Oct 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment