New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevents non-existent directories from ending up in list of files to import #8

Merged
merged 1 commit into from Jul 4, 2017

Conversation

2 participants
@drrobotnik
Contributor

drrobotnik commented Jun 20, 2017

Discovered that if you type a directory to import incorrectly, is_dir will return false but the incorrect directory will end up in the new_args array of files to import. This adds an additional condition to ensure the file exists.

fixes non-existent directories from ending up in list of files to import
Discovered that if you type a directory to import incorrectly, is_dir will return false but the incorrect directory will end up in the new_args array of files to import. This adds an additional condition to ensure the file exists.
@danielbachhuber

Thanks @drrobotnik ! Can you add a test case for this change so we don't get bitten by it again?

@danielbachhuber danielbachhuber changed the title from fixes non-existent directories from ending up in list of files to import to Prevents non-existent directories from ending up in list of files to import Jul 4, 2017

@danielbachhuber danielbachhuber added this to the 1.0.2 milestone Jul 4, 2017

@danielbachhuber danielbachhuber merged commit 3d10d13 into wp-cli:master Jul 4, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment