New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `language plugin` and `language theme` command. #29

Merged
merged 9 commits into from Aug 2, 2018

Conversation

3 participants
@gitlost
Contributor

gitlost commented Jan 25, 2018

Closes #24

Restored from #21 after revert #28

Original @swissspidy:

This fixes #24 (originally wp-cli/wp-cli#3782).

Things that still needs to be done/decided, among others:

  • Decide whether wp language plugin install hello-dolly en_GB would accept an --activate flag.
    Activating a language is a global action per site. One cannot activate language X for plugin A and language Y for plugin B. Hence, I think only the core command should allow activating languages.
    The answer is no. Activating a language should be separate.
  • Implement uninstall commands.
    \WP_CLI\CommandWithTranslation::uninstall() currently respects the object type, but doesn't know about the plugin/theme slug.
  • Implement update commands.
    \WP_CLI\CommandWithTranslation::update() currently updates all translations.
    Should wp language core update only update translations for core and wp language plugin update for plugins (or a specific plugin?).
    The answer is yes. If someone wants to update all files, they can use something like for type in core plugin theme; do wp language $type update; done
@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Jan 25, 2018

Contributor

See also #27

Edit: ah, made a bags of this.

Contributor

gitlost commented Jan 25, 2018

See also #27

Edit: ah, made a bags of this.

@schlessera schlessera requested a review from wp-cli/committers Apr 3, 2018

swissspidy added some commits Jun 19, 2018

@schlessera schlessera added this to the 1.0.8 milestone Aug 2, 2018

@schlessera schlessera merged commit e0e526d into master Aug 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the wip-plugin-theme-command branch Aug 2, 2018

@schlessera schlessera changed the title from Add plugin and theme command. to Add `language plugin` and `language theme` command. Aug 2, 2018

@swissspidy

This comment has been minimized.

Show comment
Hide comment
@swissspidy

swissspidy Aug 2, 2018

Contributor

@schlessera I thought there were still some things missing, hence the revert in #28? Or do you want to work on that in future iterations?

Contributor

swissspidy commented Aug 2, 2018

@schlessera I thought there were still some things missing, hence the revert in #28? Or do you want to work on that in future iterations?

@swissspidy swissspidy referenced this pull request Aug 2, 2018

Closed

Change activate command #23

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 2, 2018

Member

Well, you made some changes, and it looked complete to me. Are there things you think are missing/incomplete/broken?

Member

schlessera commented Aug 2, 2018

Well, you made some changes, and it looked complete to me. Are there things you think are missing/incomplete/broken?

@swissspidy

This comment has been minimized.

Show comment
Hide comment
@swissspidy

swissspidy Aug 2, 2018

Contributor

No, not really. Besides these changes I made, I can't remember what else specifically was missing or incomplete back in January. #28 was a bit vague :-)

I'll work on #27 though, and maybe #22.

Contributor

swissspidy commented Aug 2, 2018

No, not really. Besides these changes I made, I can't remember what else specifically was missing or incomplete back in January. #28 was a bit vague :-)

I'll work on #27 though, and maybe #22.

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 2, 2018

Member

#27 seems important, as I just had that issue without knowing what was going on.

Member

schlessera commented Aug 2, 2018

#27 seems important, as I just had that issue without knowing what was going on.

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 2, 2018

Member

What does not work as we had initially discussed is that operations like update automatically work across all plugins/themes and language packs are always downloaded in their latest version, irregardless of what version of the plugin/theme is installed.

But I think of these are limitations of the infrastructure that we cannot easily get around, aren't they?

Member

schlessera commented Aug 2, 2018

What does not work as we had initially discussed is that operations like update automatically work across all plugins/themes and language packs are always downloaded in their latest version, irregardless of what version of the plugin/theme is installed.

But I think of these are limitations of the infrastructure that we cannot easily get around, aren't they?

@swissspidy

This comment has been minimized.

Show comment
Hide comment
@swissspidy

swissspidy Aug 2, 2018

Contributor

Ah. I'll try to test this locally. Maybe we can find a workaround if that's still an issue.

It would be great to have this documented in the tests somehow.

Contributor

swissspidy commented Aug 2, 2018

Ah. I'll try to test this locally. Maybe we can find a workaround if that's still an issue.

It would be great to have this documented in the tests somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment