New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for `wp site switch-language` #57

Merged
merged 1 commit into from Sep 14, 2018

Conversation

2 participants
@swissspidy
Copy link
Contributor

swissspidy commented Sep 14, 2018

Adding some tests to confirm whether it's really an issue.

See #55.

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Sep 14, 2018

Test logic looks sound to me, except for the fact that you only check whether languages have been installed, but not check whether they weren't installed before. But that would only be an unrelated issue anyway.

@schlessera schlessera added this to the 2.0.2 milestone Sep 14, 2018

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Sep 14, 2018

I'll merge this so that the @reitermarkus can run the test on their local machine to see what the result is.

@schlessera schlessera merged commit b17cdd8 into master Sep 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the 55-tests branch Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment