Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to changes in WP 5.3 image handling to fix broken tests #115

Merged
merged 9 commits into from Sep 25, 2019

Conversation

@schlessera
Copy link
Member

schlessera commented Sep 25, 2019

  • Uses new wp_get_original_image_path() function to retrieve filepath to images.
  • Skips media reorientation tests on WP 5.3+, as this is done by Core already.
  • Adapts to newly added image size 2048x2048
schlessera added 3 commits Sep 24, 2019
… images
@schlessera schlessera requested a review from wp-cli/committers as a code owner Sep 25, 2019
schlessera added 4 commits Sep 25, 2019
package-lock.json Outdated Show resolved Hide resolved
@schlessera schlessera requested a review from wp-cli/committers Sep 25, 2019
@swissspidy swissspidy merged commit 98102a5 into master Sep 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@swissspidy swissspidy deleted the fix-test-failures-with-5-3-beta-1 branch Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.