Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Skip non-thumbnailed PDFS & other images rather than fail. Check retu… #48
Skips rather than fails when PDF thumbnails are not available or when images such as SVGs are encountered.
Some re-factoring is involved re changing
But the main functionality change is checking the return values of WP core functions re #43, and acting accordingly.
A default behaviour test
Edit should add that test audio and video files have temporarily been put on my server pending upload to wp-cli.org.
Is there specific feedback you're looking for?
There's a lot of code churn, so it's difficult to comment on the diff directly. However, my historic opinion of this code is that it's been a mess, so I welcome the work cleaning it up. I feel reasonably confident in the test coverage around the functionality, so not terribly concerned about breakage.
You can upload them and then they will magically be available: https://github.com/wp-cli/wp-cli.github.com/tree/master/behat-data