New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate ghostscript/imagick install; fix bmp name in regenerate test. #69

Merged
merged 4 commits into from Feb 25, 2018

Conversation

2 participants
@gitlost
Contributor

gitlost commented Feb 18, 2018

See #44 and #61

Reinstates ghostscript/imagick install which got overwritten by #44. This means that a number of tests weren't getting run for months 馃槩

Fixes BMP filename added in #61

Also adds travis-before_install-append.yml which will be used by PR to scaffold-package-command to allow for package-specific stuff to be added to .travis.yml.

@gitlost gitlost added this to the 1.1.5 milestone Feb 18, 2018

This was referenced Feb 19, 2018

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Feb 20, 2018

Member

Also adds travis-before_install-append.yml which will be used by PR to scaffold-package-command to allow for package-specific stuff to be added to .travis.yml.

Waiting for that matching PR before merging this one.

Member

schlessera commented Feb 20, 2018

Also adds travis-before_install-append.yml which will be used by PR to scaffold-package-command to allow for package-specific stuff to be added to .travis.yml.

Waiting for that matching PR before merging this one.

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Feb 22, 2018

Contributor

The 81a803b commit moves the remove_old_images() function into needs_regeneration(), and splits the $image_sizes check in two so that thumbnails don't get destroyed if an image is skipped.

This non-destructiveness should also really extend to the no metadata case, but haven't come up with a nice way to do this, so leaving for the moment.

Also added some tests of this behaviour, and added some extra comments.

The 8f7bc79 commit reinstates the caching of the ImageMagick build, adding another Travis append file.

I'll do the PR on scaffold-package-command for adding the extra Travis stuff very shortly...

Contributor

gitlost commented Feb 22, 2018

The 81a803b commit moves the remove_old_images() function into needs_regeneration(), and splits the $image_sizes check in two so that thumbnails don't get destroyed if an image is skipped.

This non-destructiveness should also really extend to the no metadata case, but haven't come up with a nice way to do this, so leaving for the moment.

Also added some tests of this behaviour, and added some extra comments.

The 8f7bc79 commit reinstates the caching of the ImageMagick build, adding another Travis append file.

I'll do the PR on scaffold-package-command for adding the extra Travis stuff very shortly...

@gitlost gitlost requested a review from wp-cli/committers Feb 22, 2018

@schlessera schlessera merged commit 3923852 into master Feb 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the reinstate-imagick-gs-install branch May 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment