New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH#29 Added depreciation notice #36

Merged
merged 5 commits into from Sep 29, 2017

Conversation

3 participants
@Sidsector9
Member

Sidsector9 commented Sep 18, 2017

Fixes #29

@Sidsector9 Sidsector9 changed the title from GH#29 Added deprication notice to GH#29 Added depreciation notice Sep 18, 2017

@danielbachhuber

We should update the command documentation with this message too.

@Sidsector9

This comment has been minimized.

Show comment
Hide comment
@Sidsector9

Sidsector9 Sep 19, 2017

Member

@danielbachhuber, part of the function doc block?

Member

Sidsector9 commented Sep 19, 2017

@danielbachhuber, part of the function doc block?

@miya0001

This comment has been minimized.

Show comment
Hide comment
@Sidsector9

This comment has been minimized.

Show comment
Hide comment
@Sidsector9

Sidsector9 Sep 19, 2017

Member

@miya0001 can you confirm if this is updated correctly?

Member

Sidsector9 commented Sep 19, 2017

@miya0001 can you confirm if this is updated correctly?

@miya0001

This comment has been minimized.

Show comment
Hide comment
@miya0001

miya0001 Sep 19, 2017

Member

If you run wp package browse --format=yaml, then we can see like following.
There should be notice which is added by this PR.

$ wp package browse --format=yaml
Although the package index will remain in place for backward compatibility reasons, it has been deprecated and will not be updated further.
Please refer to https://github.com/wp-cli/ideas/issues/51 to read about its potential replacement.
---
- 
  name: 10up/mu-migration
  description: A set of WP-CLI commands to support the migration of single WordPress instances to multisite
  authors: Nícholas André
  version: dev-master, dev-develop, dev-feature/tables-param, dev-feature/users-mapping-improvements

So, we should add same notice to the following example. :)
https://github.com/Sidsector9/package-command/blob/76844055dbc8edc6e20ec45a102e0c77338f21c8/src/Package_Command.php#L116-L136

Member

miya0001 commented Sep 19, 2017

If you run wp package browse --format=yaml, then we can see like following.
There should be notice which is added by this PR.

$ wp package browse --format=yaml
Although the package index will remain in place for backward compatibility reasons, it has been deprecated and will not be updated further.
Please refer to https://github.com/wp-cli/ideas/issues/51 to read about its potential replacement.
---
- 
  name: 10up/mu-migration
  description: A set of WP-CLI commands to support the migration of single WordPress instances to multisite
  authors: Nícholas André
  version: dev-master, dev-develop, dev-feature/tables-param, dev-feature/users-mapping-improvements

So, we should add same notice to the following example. :)
https://github.com/Sidsector9/package-command/blob/76844055dbc8edc6e20ec45a102e0c77338f21c8/src/Package_Command.php#L116-L136

@danielbachhuber danielbachhuber added this to the 1.0.5 milestone Sep 29, 2017

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Sep 29, 2017

Member

@Sidsector9 @miya0001 Although it's probably not an issue in this case, we should avoid breaking machine-readable output (e.g. don't display notices when --format=(yaml|json)

Member

danielbachhuber commented Sep 29, 2017

@Sidsector9 @miya0001 Although it's probably not an issue in this case, we should avoid breaking machine-readable output (e.g. don't display notices when --format=(yaml|json)

@Sidsector9 Sidsector9 merged commit a8f5b9c into wp-cli:master Sep 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment