New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repository entry when uninstalling packages #37

Merged
merged 4 commits into from Sep 24, 2017

Conversation

2 participants
@Sidsector9
Member

Sidsector9 commented Sep 18, 2017

See #25

@Sidsector9 Sidsector9 requested a review from wp-cli/committers Sep 18, 2017

@@ -158,6 +158,7 @@ Feature: Install WP-CLI packages
Then STDOUT should contain:
"""
Removing require statement from {PACKAGE_PATH}composer.json
Removing repository details from {PACKAGE_PATH}composer.json

This comment has been minimized.

@schlessera

schlessera Sep 18, 2017

Member

This only tests that there was console output.

The test should also verify that the repository setting has effectively been removed from the composer.json file.

@schlessera

schlessera Sep 18, 2017

Member

This only tests that there was console output.

The test should also verify that the repository setting has effectively been removed from the composer.json file.

This comment has been minimized.

@Sidsector9

Sidsector9 Sep 19, 2017

Member

Made the changes @schlessera

@Sidsector9

Sidsector9 Sep 19, 2017

Member

Made the changes @schlessera

Show outdated Hide outdated features/package-install.feature Outdated

@schlessera schlessera added this to the 1.0.5 milestone Sep 24, 2017

@schlessera schlessera merged commit 94106e9 into wp-cli:master Sep 24, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera changed the title from GH#25 Remove repository details from composer.json to Remove repository entry when uninstalling packages Sep 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment