New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume default package name if composer.json file cannot be retrieved #78

Merged
merged 4 commits into from Apr 19, 2018

Conversation

3 participants
@emirpprime

emirpprime commented Apr 13, 2018

  • Warning, not Error, when composer.json cannot be retrieved
  • Return best-guess $package_name
Phil Banks
Handle unavailable composer.json on private repo
- Warning not Error when composer.json cannot be retreived
- Return best-guess $package_name
@emirpprime

This comment has been minimized.

emirpprime commented Apr 13, 2018

Realised I've broken other tests. Fixing.

Phil Banks added some commits Apr 13, 2018

Phil Banks
Phil Banks
don't use array dereferencing
- requires PHP >= 5.4
@emirpprime

This comment has been minimized.

emirpprime commented Apr 13, 2018

Previous test failed due to OOM error, but I realised that array dereferencing isn't supported in 5.3 anyway so I've updated to remove that.

@emirpprime

This comment has been minimized.

emirpprime commented Apr 13, 2018

OOM again ¯_(ツ)_/¯

@schlessera

This comment has been minimized.

Member

schlessera commented Apr 14, 2018

@emirpprime The OOM should now be fixed if you merge latest master.

@danielbachhuber

This comment has been minimized.

Member

danielbachhuber commented Apr 14, 2018

I've merged master.

@schlessera schlessera merged commit 63bfef0 into wp-cli:master Apr 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Member

schlessera commented Apr 19, 2018

Thanks for the pull request, @emirpprime !

@schlessera schlessera changed the title from Handle unavailable composer.json on private repo (issue #76) to Assume default package name if composer.json file cannot be retrieved Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment