New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt package for framework v2 #87

Merged
merged 9 commits into from Aug 5, 2018

Conversation

2 participants
@schlessera
Member

schlessera commented Aug 4, 2018

Fixes #86

schlessera and others added some commits Aug 4, 2018

@swissspidy

This comment has been minimized.

Show comment
Hide comment
@swissspidy

swissspidy Aug 4, 2018

Contributor
Could not open input file: vendor/bin/../../utils/make-phar.php

Where is that script located now?

Or should that test be removed?

Contributor

swissspidy commented Aug 4, 2018

Could not open input file: vendor/bin/../../utils/make-phar.php

Where is that script located now?

Or should that test be removed?

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 4, 2018

Member

That script is now part of the wp-cli/wp-cli-bundle package and located at utils/make-phar.php in that package.

Member

schlessera commented Aug 4, 2018

That script is now part of the wp-cli/wp-cli-bundle package and located at utils/make-phar.php in that package.

@swissspidy

This comment has been minimized.

Show comment
Hide comment
@swissspidy
Contributor

swissspidy commented Aug 4, 2018

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 4, 2018

Member

@swissspidy No, I moved tests that create new Phars into the wp-cli/wp-cli-bundle repository. We should move this one too.

Member

schlessera commented Aug 4, 2018

@swissspidy No, I moved tests that create new Phars into the wp-cli/wp-cli-bundle repository. We should move this one too.

schlessera added some commits Aug 4, 2018

Remove tests that require `make-phar.php`
These need to be moved into `wp-cli/wp-cli-bundle`. See wp-cli/wp-cli-bundle#2

@schlessera schlessera added this to the 2.0.0 milestone Aug 5, 2018

@schlessera schlessera merged commit e0e0980 into master Aug 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the adapt-for-v2 branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment