New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing off-by-1 error in progress bar examples #128

Merged
merged 1 commit into from Mar 12, 2018

Conversation

2 participants
@lf-jeremy
Contributor

lf-jeremy commented Mar 8, 2018

Fixes #127

Resolves off-by-1 error in test_notify function.

While changing the comparison operator fixes this issue, the need for a tick count parameter could be avoided altogether as described in this issue comment. Given the normal use case is to tick a number of times equal to the progress bar tick total, the passed progress bar object could be introspected if appropriately exposed.

@schlessera schlessera merged commit 69863a0 into wp-cli:master Mar 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera added this to the 0.11.9 milestone Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment