New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sed -i option on MacOS #132

Merged
merged 1 commit into from Mar 27, 2018

Conversation

3 participants
@ptrkcsk
Contributor

ptrkcsk commented Mar 6, 2018

The -i syntax is: -i[SUFFIX]. There should be no space between -i
and the suffix. See sed Command Line Options.

Before this fix, I saw the following error on macOS:

sed: -e expression #1, char 1: unknown command: `.'
Fix sed -i option
The -i syntax is: `-i[SUFFIX]`. There should be no space between `-i`
and the suffix. See https://www.gnu.org/software/sed/manual/sed.html#Command_002dLine-Options-1
@ptrkcsk

This comment has been minimized.

Contributor

ptrkcsk commented Mar 6, 2018

Oops. Looks like maybe this broke other things. I'll investigate further.

@gitlost

This comment has been minimized.

Contributor

gitlost commented Mar 6, 2018

@ptrkcsk that's not you that broke that, it's due to this recent change in core trunk https://core.trac.wordpress.org/ticket/43228 which hopefully will be addressed soon (if not we'll have to do a workaround). (See also wp-cli/wp-cli#4718 (comment))

Thanks for the PR by the way! Not a Mac user, but it's odd to me that this issue has only been noticed now?!

@ptrkcsk

This comment has been minimized.

Contributor

ptrkcsk commented Mar 7, 2018

Not a Mac user, but it's odd to me that this issue has only been noticed now?!

Developing without virtualization is so 2008. 🙂

@schlessera schlessera added this to the 1.1.3 milestone Mar 27, 2018

@schlessera schlessera merged commit a9d4346 into wp-cli:master Mar 27, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Member

schlessera commented Mar 27, 2018

Thanks for the pull request, @ptrkcsk !

@ptrkcsk

This comment has been minimized.

Contributor

ptrkcsk commented Mar 27, 2018

Glad I could help!

@schlessera schlessera changed the title from Fix sed -i option to Fix sed -i option on MacOS Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment