New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tests/test-sample.php via the phpunit.xml.dist file #134

Merged
merged 3 commits into from Apr 10, 2018

Conversation

2 participants
@stevegrunwell
Contributor

stevegrunwell commented Apr 6, 2018

This commit adds ./tests/test-sample.php as an exclusion in the phpunit.xml.dist file, preventing it from executing by default when developers run PHPUnit.

Keeping the sample file can be helpful for projects (for instance, if the project is using a custom base test case and/or namespaces), but constantly asserting that true is, in fact, true isn't helpful.

stevegrunwell added some commits Apr 6, 2018

Exclude tests/test-sample.php via the phpunit.xml.dist file
This commit adds ./tests/test-sample.php as an exclusion in the phpunit.xml.dist file, preventing it from executing by default when developers run PHPUnit.

Keeping the sample file can be helpful for projects (for instance, if the project is using a custom base test case and/or namespaces), but constantly asserting that true is, in fact, true isn't helpful.
Running the tests within a scaffolded plugin within our test suite is…
… a more complicated process than it seemed, so skip that for now (since the change is already reflected in the theme scaffold tests)
@stevegrunwell

This comment has been minimized.

Contributor

stevegrunwell commented Apr 6, 2018

Failing tests are due to PHP 5.3 running out of memory, which is addressed in #136.

@danielbachhuber danielbachhuber merged commit c4346a2 into wp-cli:master Apr 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stevegrunwell stevegrunwell deleted the stevegrunwell:feature/skip-sample-test-in-phpunit-config branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment