New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 7.2 to CI templates #135

Merged
merged 3 commits into from Apr 10, 2018

Conversation

@stevegrunwell
Contributor

stevegrunwell commented Apr 6, 2018

WordPress 4.9.5 bumped the recommended PHP version to 7.2, so themes and plugins should probably make a point of supporting them.

This PR adds PHP 7.2 to the testing matricies for all of the CI providers, using the same settings as we were using for PHP 7.1.

stevegrunwell added some commits Apr 6, 2018

Add PHP 7.2 to CI templates
WordPress 4.9.5 bumped the recommended PHP version to 7.2, so themes and plugins should probably make a point of supporting them.

This commit adds PHP 7.2 to the testing matricies for all of the CI providers, using the same settings as we were using for PHP 7.1.
@stevegrunwell

This comment has been minimized.

Contributor

stevegrunwell commented Apr 6, 2018

Failing tests are due to PHP 5.3 running out of memory, which is addressed in #136.

@danielbachhuber danielbachhuber merged commit 09769c6 into wp-cli:master Apr 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@stevegrunwell stevegrunwell deleted the stevegrunwell:feature/add-php72-to-testing-matrix branch Apr 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment