New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify scaffold block to create index.js #142

Merged
merged 1 commit into from Apr 19, 2018

Conversation

2 participants
@salcode
Contributor

salcode commented Apr 17, 2018

Modify scaffold block to create index.js instead of block.js
This is recommended as a best practice by @zgordon
This optimization allows one to import a block in JavaScript with

import './demo/';

rather than

import './demo/block.js';

See #138

Modify scaffold block to create index.js
Modify scaffold block to create index.js instead of block.js
This is recommended as a best practice by @zgordon
This optimization allows one to import a block in JavaScript with

import './demo/';

rather than

import './demo/block.js';

See #138

@schlessera schlessera merged commit 1d815f3 into wp-cli:master Apr 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Member

schlessera commented Apr 19, 2018

Thanks for the pull-request, @salcode !

@salcode

This comment has been minimized.

Contributor

salcode commented Apr 19, 2018

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment