New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'wp-blocks' from style dependency #151

Merged
merged 1 commit into from May 19, 2018

Conversation

4 participants
@ajitbohra
Contributor

ajitbohra commented May 18, 2018

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo May 18, 2018

Contributor

Thanks @ajitbohra for opening this PR 👍

Contributor

gziolo commented May 18, 2018

Thanks @ajitbohra for opening this PR 👍

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo May 18, 2018

Contributor

I see that @youknowriad updated handbook to make styles dependent on wp-edit-blocks. I think this in the case when someone wants to override the styles coming from Core blocks. Whatever we decide we should make sure that Gutenberg handbook is updated with whatever we agree upon here.

Contributor

gziolo commented May 18, 2018

I see that @youknowriad updated handbook to make styles dependent on wp-edit-blocks. I think this in the case when someone wants to override the styles coming from Core blocks. Whatever we decide we should make sure that Gutenberg handbook is updated with whatever we agree upon here.

@youknowriad

This comment has been minimized.

Show comment
Hide comment
@youknowriad

youknowriad May 18, 2018

Actually, what I did is removing the wp-blocks dependency. I don't think third party styles should depend on any Gutenberg styles unless they reuse components from editor or something else. I think by default it should be an empty array.

youknowriad commented May 18, 2018

Actually, what I did is removing the wp-blocks dependency. I don't think third party styles should depend on any Gutenberg styles unless they reuse components from editor or something else. I think by default it should be an empty array.

@ajitbohra

This comment has been minimized.

Show comment
Hide comment
@ajitbohra

ajitbohra May 18, 2018

Contributor

@gziolo So far have been adding wp-blocks as the dependency to blocks style. A few days back @youknowriad mentioned on PR/Slack it's not needed, have stopped adding it as a dependency. Blocks & plugins seem to work fine.

In most scenarios wp-blocks is not required as a dependency for block style or editor_style except case mentioned above.

Whatever we decide we should also get the same implemented in create-guten-block.

Contributor

ajitbohra commented May 18, 2018

@gziolo So far have been adding wp-blocks as the dependency to blocks style. A few days back @youknowriad mentioned on PR/Slack it's not needed, have stopped adding it as a dependency. Blocks & plugins seem to work fine.

In most scenarios wp-blocks is not required as a dependency for block style or editor_style except case mentioned above.

Whatever we decide we should also get the same implemented in create-guten-block.

@schlessera schlessera merged commit fc55f31 into wp-cli:master May 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera added this to the 1.1.4 milestone May 19, 2018

@ajitbohra ajitbohra referenced this pull request May 19, 2018

Open

Incorrect dependencies #55

@gziolo

This comment has been minimized.

Show comment
Hide comment
@gziolo

gziolo May 21, 2018

Contributor

@schlessera, thanks for the quick review 💯

Contributor

gziolo commented May 21, 2018

@schlessera, thanks for the quick review 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment