New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHPCompatibility sniffs to scaffolded #154

Merged
merged 3 commits into from Jun 3, 2018

Conversation

2 participants
@yousan
Contributor

yousan commented Jun 3, 2018

Add PHPCompatibility sniffs to scaffolded

fixes #60

@yousan yousan changed the title from Add test case to fail to (Not yet) Add test case to fail Jun 3, 2018

@yousan yousan closed this Jun 3, 2018

@yousan yousan reopened this Jun 3, 2018

@yousan yousan changed the title from (Not yet) Add test case to fail to (Not yet) Add PHPCompatibility sniffs to scaffolded Jun 3, 2018

@yousan yousan changed the title from (Not yet) Add PHPCompatibility sniffs to scaffolded to Add PHPCompatibility sniffs to scaffolded Jun 3, 2018

@@ -2,6 +2,9 @@
<ruleset name="WordPress Coding Standards for Plugins">
<description>Generally-applicable sniffs for WordPress plugins</description>
<rule ref="PHPCompatibility"/>

This comment has been minimized.

@schlessera

schlessera Jun 3, 2018

Member

Instead of pulling in the general PHPCodeSniffer rule, you should pull in the Framework-specific version for WordPress, which contains some exclusions to avoid false positives. This is needed because WordPress includes a lot of compatibility code and polyfills, so the checks need to take this into account. You can see the current exclusions here: https://github.com/wimg/PHPCompatibility/blob/master/framework-rulesets/wordpress.xml

Here's the adapted rule to use:

<rule ref="./vendor/wimg/php-compatibility/framework-rulesets/wordpress.xml"/>
@schlessera

schlessera Jun 3, 2018

Member

Instead of pulling in the general PHPCodeSniffer rule, you should pull in the Framework-specific version for WordPress, which contains some exclusions to avoid false positives. This is needed because WordPress includes a lot of compatibility code and polyfills, so the checks need to take this into account. You can see the current exclusions here: https://github.com/wimg/PHPCompatibility/blob/master/framework-rulesets/wordpress.xml

Here's the adapted rule to use:

<rule ref="./vendor/wimg/php-compatibility/framework-rulesets/wordpress.xml"/>

This comment has been minimized.

@yousan

yousan Jun 3, 2018

Contributor

Thank you for your reviewing.

Can vendor directory place at template directory?

@yousan

yousan Jun 3, 2018

Contributor

Thank you for your reviewing.

Can vendor directory place at template directory?

This comment has been minimized.

@schlessera

schlessera Jun 3, 2018

Member

No, that would be pulled in via Composer. But now that you're mentioning it, I don't think we're using Composer for the scaffolded plugins...

Let's merge this PR as-is for now and create an issue for evaluating how to use the Framework-specific ruleset in the future.

@schlessera

schlessera Jun 3, 2018

Member

No, that would be pulled in via Composer. But now that you're mentioning it, I don't think we're using Composer for the scaffolded plugins...

Let's merge this PR as-is for now and create an issue for evaluating how to use the Framework-specific ruleset in the future.

This comment has been minimized.

@yousan

yousan Jun 3, 2018

Contributor

Can I see other plugin which uses Composer, and adapt it for scaffolded?

@yousan

yousan Jun 3, 2018

Contributor

Can I see other plugin which uses Composer, and adapt it for scaffolded?

This comment has been minimized.

@schlessera

schlessera Jun 4, 2018

Member

I don't think adding Composer support directly is a good idea at this point. Most plugin developers will not know what this means.

This needs more thought and exploration first. I've created a corresponding issue for now: #155

@schlessera

schlessera Jun 4, 2018

Member

I don't think adding Composer support directly is a good idea at this point. Most plugin developers will not know what this means.

This needs more thought and exploration first. I've created a corresponding issue for now: #155

@schlessera schlessera merged commit 3c1d0e2 into wp-cli:master Jun 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera added this to the 1.1.4 milestone Jun 3, 2018

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jun 4, 2018

Member

Thanks for the pull-request, @yousan !

Member

schlessera commented Jun 4, 2018

Thanks for the pull-request, @yousan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment