New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--woocommerce` flag to `scaffold _s` command #159

Merged
merged 3 commits into from Jul 20, 2018

Conversation

2 participants
@CodeProKid
Contributor

CodeProKid commented Jul 20, 2018

Added the new --woocommerce flag to the scaffold _s command.

First time writing behat tests, so hopefully I got them right. The only test I wrote was basically to assert two of the WooCommerce files existed. Not sure if the tests should be more in depth than that, or if there should also be a test to assert the WooCommerce files don't exist when the flag isn't present.

@schlessera

Looks great, @CodeProKid, only a minor code style change needed.

Show outdated Hide outdated src/Scaffold_Command.php
@CodeProKid

This comment has been minimized.

Show comment
Hide comment
@CodeProKid

CodeProKid Jul 20, 2018

Contributor

Thanks @schlessera, this has been fixed 👍

Contributor

CodeProKid commented Jul 20, 2018

Thanks @schlessera, this has been fixed 👍

@schlessera schlessera added this to the 1.1.4 milestone Jul 20, 2018

@schlessera schlessera merged commit e5cb0a8 into wp-cli:master Jul 20, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera changed the title from fixes #139 adding --woocommerce flag to scaffold _s command to Add `--woocommerce` flag to `scaffold _s` command Jul 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment