Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
PHPCS template: fix XML error in ruleset #171
This was caused by an unclosed comment in the XML. This PR fixes it.
The PR can be tested by:
@swissspidy That's how I've implemented it a while ago in WPCS - both validation as well as an XML codestyle check. See: https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/blob/eccb1f721f95fdcf5c2e383340aa4b094c0317ad/.travis.yml#L112-L122
@jrfnl Linting the XML sounds good. However, this is currently a template file, so it might not pass the linter because of that. What I had been thinking recently is to let Travis actually use the scaffolding command to scaffold a plugin/theme, and then run tests against that scaffolded result.
I'll open a separate issue to that regard.
Thanks for this PR, @jrfnl !
Aug 14, 2018
1 check passed
It actually does pass the linter as it is now this PR has been merged, so that's not an issue.
That sounds interesting ;-)
I haven't used the scaffold command myself yet, so this may already be covered, but in case it's not: it may also be useful to adjust the values for some of the customizable properties in the XML ruleset when doing the scaffolding.