Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to blocks documentation #199

Merged
merged 1 commit into from Jan 31, 2019

Conversation

@ajitbohra
Copy link
Contributor

commented Jan 29, 2019

Fixes dead links.

@ajitbohra ajitbohra referenced this pull request Jan 29, 2019
@gziolo

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

Looks great, all links work properly. I can't accept officially, but 👍 from me.

Should we include the link to JavaScript in WordPress tutorial which was added to the handbook recently:
https://wordpress.org/gutenberg/handbook/designers-developers/developers/tutorials/javascript/

I'm not quite sure, it might be good for those not familiar with JavaScript but fluent in PHP.

@ajitbohra

This comment has been minimized.

Copy link
Contributor Author

commented Jan 29, 2019

Sounds good, we can add this link in the php template, will help people easily discover tutorials.

Or maybe we can add the link to tutorial landing in both JS and PHP template https://wordpress.org/gutenberg/handbook/designers-developers/developers/tutorials/

Whats the best place to add the link ?

@schlessera

This comment has been minimized.

Copy link
Member

commented Jan 29, 2019

I'm not sure, but I'd say the link to the JavaScript tutorial seems out of scope here.

@schlessera

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

I'll merge this as-is for now. We can still discuss adding JavaScript tutorials in a separate issue if you feel this is needed.

@schlessera schlessera added this to the 2.0.5 milestone Jan 31, 2019

@schlessera schlessera merged commit 735e626 into wp-cli:master Jan 31, 2019

2 checks passed

DEP All dependencies are resolved
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

Thanks for the PR, @ajitbohra!

@gziolo

This comment has been minimized.

Copy link
Contributor

commented Jan 31, 2019

I'll merge this as-is for now. We can still discuss adding JavaScript tutorials in a separate issue if you feel this is needed.

It wouldn't harm to add it somewhere, but it also isn't essential for the success of understanding the code generated. Totally optional in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.