Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent creating unregisterable blocks due to invalid plugin slug #203

Merged
merged 3 commits into from Apr 21, 2019

Conversation

@kuoko
Copy link
Contributor

commented Apr 5, 2019

The purpose of this PR is to prevent nonworking gutenberg blocks.
More details here: #191

@kuoko kuoko requested a review from wp-cli/committers as a code owner Apr 5, 2019

src/Scaffold_Command.php Outdated Show resolved Hide resolved
Update src/Scaffold_Command.php
Co-Authored-By: kuoko <kuoko@users.noreply.github.com>

@schlessera schlessera added this to the 2.0.5 milestone Apr 5, 2019

@schlessera schlessera changed the title prevent nonworking gutenberg blocks Prevent creating unregisterable blocks due to invalid plugin slug Apr 5, 2019

@schlessera schlessera merged commit 86ee481 into wp-cli:master Apr 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

Thanks for the PR, @kuoko !

@kuoko

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

It was a pleasure. @schlessera

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.