Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts added to plugin `package.json` #225

Merged

Conversation

@derweili
Copy link
Contributor

derweili commented Apr 26, 2019

This PR is related to issue #224

1. `start` This represents the default grunt task in Gruntfile.js
2. `readme` This script represents the Grunt Task for Readme.md generation
3. `i18n` This script represents the Grund Task for .pot generation
@derweili derweili requested a review from wp-cli/committers as a code owner Apr 26, 2019
@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Apr 26, 2019

We need to document this somewhere as well. As the generated readme for the plugin is useless (only placeholder content), the best place is probably to add it to the command description here: https://github.com/wp-cli/scaffold-command/blob/v2.0.6/src/Scaffold_Command.php#L589-L606

@derweili

This comment has been minimized.

Copy link
Contributor Author

derweili commented May 5, 2019

I added the scripts to the command description.

@swissspidy

This comment has been minimized.

Copy link
Member

swissspidy commented May 5, 2019

We should really use some more modern scripts there at some point.

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Aug 6, 2019

Related: #233

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Aug 12, 2019

I'm merging this now, knowing that the ultimate goal should be to modernize the tooling in general.

Having the scripts in place makes swapping the tooling out easier for people already relying on these scripts.

@schlessera schlessera added this to the 2.0.7 milestone Aug 12, 2019
@schlessera schlessera merged commit 34e3dbf into wp-cli:master Aug 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera schlessera changed the title Scripts added to plugin package.json Scripts added to plugin `package.json` Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.