Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch test prep feature from global PHPUnit to local PHPUnit #235

Closed
wants to merge 1 commit into from

Conversation

@schlessera
Copy link
Member

schlessera commented Aug 12, 2019

This should fix the issue that PHPUnit 4.8 is used, even in PHP 7.2, throwing notices...

@schlessera schlessera requested a review from wp-cli/committers as a code owner Aug 12, 2019
@schlessera schlessera added this to the 2.0.7 milestone Aug 12, 2019
@schlessera

This comment has been minimized.

Copy link
Member Author

schlessera commented Aug 12, 2019

Closing, this does neither work, nor would it fix the problem, as we have the platform setting locking PHP to 5.4, and the only PHPUnit version that supports such a low PHP version is 4.8.x indeed.

@schlessera schlessera closed this Aug 12, 2019
@schlessera schlessera deleted the switch-tests-from-global-to-local-phpunit branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.