New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cater for symbolic links. Add canonicalize_path and use in check_target_directory. #26

Merged
merged 5 commits into from Jun 14, 2017

Conversation

2 participants
@gitlost
Contributor

gitlost commented Jun 12, 2017

Issue #22

Adds canonicalize_path() and uses in check_target_directory() in place of realpath() to avoid symbolic link issues.

Adds some feedback by appending various reasons to the "Invalid plugin/theme slug specified." error messages. Involves changing check_target_directory() to return error string instead of bool.

@danielbachhuber danielbachhuber merged commit 924e784 into wp-cli:master Jun 14, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment