New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest branch for test library, and always get the latest major release when 2 digit wp versions are used #35

Merged
merged 5 commits into from Aug 11, 2017

Conversation

4 participants
@jdub233
Contributor

jdub233 commented Aug 7, 2017

This PR scans the latest releases and gets the most up to date release when a 2 digit version is specified. To force the use of the original release, one can specify .0, for example 4.7.0. Also fetches the latest test suite.

Builds on #34

Fixes #18

@miya0001

This comment has been minimized.

Show comment
Hide comment
@miya0001

miya0001 Aug 8, 2017

Member

I tested with #37 then this PR seems to work well.

Member

miya0001 commented Aug 8, 2017

I tested with #37 then this PR seems to work well.

Show outdated Hide outdated templates/install-wp-tests.sh Outdated
Show outdated Hide outdated templates/install-wp-tests.sh Outdated
@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Aug 8, 2017

Member

@jdub233 Can you merge master to include #37?

Member

danielbachhuber commented Aug 8, 2017

@jdub233 Can you merge master to include #37?

@danielbachhuber

Looks good 👍 To @schlessera for the final review

@schlessera

I have one additional change request.
I know we won't be able to easily make this 100% cross-platform, but I think the current use of the /tmp folder can cause all sorts of issues, even on compatible platforms.
I'd prefer the temporary paths to rely on $TMPDIR instead, as that can then point to /tmp, /var/tmp or whatever user-specific temporary folder is meant to be used. Also, it provides a way to override the folder as well.

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 11, 2017

Member

Nevermind the /tmp folder observation, that has nothing to do with this PR. Let's merge this and open a new issue for the temporary path.

Member

schlessera commented Aug 11, 2017

Nevermind the /tmp folder observation, that has nothing to do with this PR. Let's merge this and open a new issue for the temporary path.

@schlessera schlessera merged commit 41f1e1a into wp-cli:master Aug 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 11, 2017

Member

Related issue: #38

Member

schlessera commented Aug 11, 2017

Related issue: #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment