Join GitHub today
Enhance pluralization #54
Thanks for pull-request @fumikito.
@wp-cli/committers Any thoughts?
That sounds good (and necessary).
I'm not sure why they did that in core, looks OTT. The
I see no real need, as @fumikito says.
The PHPMailer license bit was probably part of the original PHPMailer source code and just copied over.
In our case, the existing license text should be sufficient.
I would like to see 1 additional feature test that uses one of the inflections that were not part of the previous code. This will allow us to detect regressions where we're relying on an old function implmentation.