New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS: Show progress when invoking phpcs #64

Merged
merged 2 commits into from Oct 11, 2017

Conversation

4 participants
@GaryJones
Contributor

GaryJones commented Oct 11, 2017

Displays the progress meter to help identify that phpcs is working.

Closes #62.

CS: Show progress when invoking phpcs
Displays the progress meter to help identify that phpcs is working.
@GaryJones

This comment has been minimized.

Show comment
Hide comment
@GaryJones

GaryJones Oct 11, 2017

Contributor

I'm unsure how that build failure is related to the change I made.

Contributor

GaryJones commented Oct 11, 2017

I'm unsure how that build failure is related to the change I made.

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber
Member

danielbachhuber commented Oct 11, 2017

@miya0001 ^

@wojsmol

This comment has been minimized.

Show comment
Hide comment
@wojsmol

wojsmol Oct 11, 2017

Contributor

@danielbachhuber @GaryJones Trunk is now in beta1 state. In test we expecting alpha state, ref

And the /tmp/behat-wordpress/wp-includes/version.php file should contain:
"""
-alpha-
"""

Contributor

wojsmol commented Oct 11, 2017

@danielbachhuber @GaryJones Trunk is now in beta1 state. In test we expecting alpha state, ref

And the /tmp/behat-wordpress/wp-includes/version.php file should contain:
"""
-alpha-
"""

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Oct 11, 2017

Member

Trunk is now in beta1 state. I m test we expecting alpha state, ref

Correct. See conversation in #61 (comment)

Member

danielbachhuber commented Oct 11, 2017

Trunk is now in beta1 state. I m test we expecting alpha state, ref

Correct. See conversation in #61 (comment)

@miya0001

This comment has been minimized.

Show comment
Hide comment
@miya0001

miya0001 Oct 11, 2017

Member

@GaryJones Please merge master into this branch to fix build failure. Thanks 😊

Member

miya0001 commented Oct 11, 2017

@GaryJones Please merge master into this branch to fix build failure. Thanks 😊

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Oct 11, 2017

Member

Please merge master into this branch to fix build failure.

I've done so.

@miya0001 Btw, for small things like merging master or making small changes, it's easier for you to make the change directly:

$ cd vendor/wp-cli/scaffold-command
$ git pull origin master
$ git remote add garyjones https://github.com/GaryJones/scaffold-command.git
$ git fetch garyjones
$ git checkout cs-phpcs-progress-meter
$ git merge master
$ git push
Member

danielbachhuber commented Oct 11, 2017

Please merge master into this branch to fix build failure.

I've done so.

@miya0001 Btw, for small things like merging master or making small changes, it's easier for you to make the change directly:

$ cd vendor/wp-cli/scaffold-command
$ git pull origin master
$ git remote add garyjones https://github.com/GaryJones/scaffold-command.git
$ git fetch garyjones
$ git checkout cs-phpcs-progress-meter
$ git merge master
$ git push
@miya0001

This comment has been minimized.

Show comment
Hide comment
@miya0001
Member

miya0001 commented Oct 11, 2017

@danielbachhuber Thanks 😊

@miya0001 miya0001 merged commit 367f4d1 into wp-cli:master Oct 11, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment