Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error message on regex check. #66

Open
gitlost opened this Issue Feb 11, 2018 · 0 comments

Comments

2 participants
@gitlost
Copy link
Contributor

gitlost commented Feb 11, 2018

The regex check at Search_Replace_Command.php#L191 just returns a fails message on false. It should return the PCRE error also, which can be got with error_get_last() (and confusingly not with preg_last_error()). Also sometimes gives an offset so it would be groovy to have it highlight or point to where in the regex that is.

Edit: maybe add this as a function in Utils as will be useful elsewhere also (eg db search).

@gitlost gitlost changed the title Better error message on regex error. Better error message on regex check. Feb 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.