New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging of search-replace transformations. #35

Merged
merged 4 commits into from Oct 12, 2017

Conversation

4 participants
@gitlost
Contributor

gitlost commented Sep 19, 2017

Fixes #1

Adds logging of before/after changes.

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Sep 20, 2017

Member

@gitlost Can you share a screencast?

Member

danielbachhuber commented Sep 20, 2017

@gitlost Can you share a screencast?

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Oct 4, 2017

Contributor
Contributor

gitlost commented Oct 4, 2017

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Oct 4, 2017

Member

@gitlost That's pretty fantastic.

Member

danielbachhuber commented Oct 4, 2017

@gitlost That's pretty fantastic.

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Oct 4, 2017

Contributor

Shucks, I'll request a review so!

Contributor

gitlost commented Oct 4, 2017

Shucks, I'll request a review so!

@gitlost gitlost requested a review from wp-cli/committers Oct 4, 2017

@miya0001

I like it! :)

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Oct 4, 2017

Member

Let's get a couple more reviews on this too.

Member

danielbachhuber commented Oct 4, 2017

Let's get a couple more reviews on this too.

@danielbachhuber

Some small nits about usage; otherwise, this looks great :)

Show outdated Hide outdated src/Search_Replace_Command.php Outdated
Show outdated Hide outdated src/Search_Replace_Command.php Outdated
Show outdated Hide outdated src/Search_Replace_Command.php Outdated
Show outdated Hide outdated src/Search_Replace_Command.php Outdated
@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Oct 12, 2017

Member

💯 Great work on this, @gitlost.

Member

danielbachhuber commented Oct 12, 2017

💯 Great work on this, @gitlost.

@danielbachhuber danielbachhuber merged commit 71cff61 into master Oct 12, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the issue_1 branch Oct 12, 2017

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Oct 13, 2017

Member

Finally got around to test this (didn't have enough data bandwidth for the Composer update yesterday).

I agree, @gitlost, this is great, and a huge improvement on the existing behaviour for more risky replacements.

Member

schlessera commented Oct 13, 2017

Finally got around to test this (didn't have enough data bandwidth for the Composer update yesterday).

I agree, @gitlost, this is great, and a huge improvement on the existing behaviour for more risky replacements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment