New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle incomplete class (un)serialization gracefully #76

Merged
merged 7 commits into from Apr 21, 2018

Conversation

1 participant
@schlessera
Member

schlessera commented Apr 19, 2018

When an unknown class is deserialized, we just throw a warning an avoid making a change, due to the lack of full knowledge of the class.

This also makes sure we don't throw a notice on PHP 7.2, which changed how is_object() deals with _PHP_Incomplete_Class.

Fixes #68

schlessera added some commits Apr 19, 2018

@schlessera schlessera added this to the 1.3.0 milestone Apr 19, 2018

@schlessera schlessera requested a review from wp-cli/committers Apr 19, 2018

schlessera added some commits Apr 19, 2018

@schlessera schlessera merged commit df1092f into master Apr 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the 68-handle-incomplete-class-serialization branch Apr 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment