Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to change the shell binary #33

Merged
merged 6 commits into from Apr 1, 2019

Conversation

@villuorav
Copy link
Contributor

commented Nov 2, 2018

Basically I have a shared hosting site, that has well,

[vhost68584ssh@procyon ~]$ which bash
/usr/local/bin/bash
[vhost68584ssh@procyon ~]$ /bin/bash
-bash: /bin/bash: No such file or directory

which means no shell-cookie-sugar-coated-sweetness for me :(

But as I am not actually a PHP person, I need some tips and pointers on how to get started with this functional testing point
"3. Please make sure to include functional tests for your changes."
Examples maybe :)

@villuorav

This comment has been minimized.

Copy link
Contributor Author

commented Nov 3, 2018

@schlessera, let me know what you think (sorry, previous comment was under wrong account)

@schlessera

This comment has been minimized.

Copy link
Member

commented Nov 5, 2018

@villuorav I'm sorry, I don't really understand what the goal of this issue is. Are you trying to add a new functionality that lets you change the default shell of a user? There is already a Unix tool for that called chsh. Also, this would be out of scope for WP-CLI.

Can you explain in more detail what you're after?

UPDATE: Oh, early in the morning for me. I completely missed that this is a PR and already comes with code.

I'll take a look at the actual code and get back to you.

src/WP_CLI/REPL.php Outdated Show resolved Hide resolved
src/WP_CLI/REPL.php Outdated Show resolved Hide resolved
src/WP_CLI/REPL.php Outdated Show resolved Hide resolved
src/WP_CLI/REPL.php Outdated Show resolved Hide resolved
@schlessera

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

@villuorav Are you still up for working on this?

schlessera and others added some commits Feb 25, 2019

Update src/WP_CLI/REPL.php
Co-Authored-By: villuorav <villuorav@users.noreply.github.com>
Apply suggestions from code review
Co-Authored-By: villuorav <villuorav@users.noreply.github.com>
@villuorav

This comment has been minimized.

Copy link
Contributor Author

commented Feb 25, 2019

Hi, sorry, completely forgot about this one

schlessera added some commits Apr 1, 2019

@villuorav villuorav requested a review from wp-cli/committers as a code owner Apr 1, 2019

@schlessera schlessera merged commit 8b2f89d into wp-cli:master Apr 1, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Thanks for the PR, @villuorav !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.