Skip to content

/widget-command

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt tests to make the widget expectations more flexible #34

Merged
merged 3 commits into from Oct 1, 2019
Merged

Adapt tests to make the widget expectations more flexible #34

merged 3 commits into from Oct 1, 2019

Conversation

@schlessera
Copy link
Member

schlessera commented Sep 25, 2019

  • Removes the requirement for widgets to be output in a given order
  • Changes the starting point check for the reste from "6 widgets" to "not 0 widgets"
@schlessera
Adapt tests to make the widget expectations more flexible
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
be1570a
@schlessera schlessera requested a review from wp-cli/committers as a code owner Sep 25, 2019
@schlessera schlessera added this to the 2.0.3 milestone Sep 25, 2019
schlessera added 2 commits Sep 30, 2019
@schlessera
Require latest master for framework
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
405f24c 
We need to require latest `dev-master` version of the `wp-cli/wp-cli` framework for now because of wp-cli/wp-cli#5283

This should be reverted again once the above PR is part of a stable release of the framework.
@schlessera
Make reset sidebar-2 test more flexible as it might already contain w…
Verified
This commit was signed with a verified signature.
schlessera Alain Schlesser
GPG key ID: 14D455078E18D81E Learn about signing commits
Loading status checks…
caeffdf 
…idgets
@thrijith
thrijith approved these changes Oct 1, 2019
View changes
@schlessera schlessera merged commit ad69fa6 into master Oct 1, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera schlessera deleted the fix-test-failures-with-5-3-beta-1 branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrijith thrijith

Assignees
No one assigned
Labels
bug scope:testing
Milestone
  2.0.3
2 participants
@schlessera @thrijith
You can’t perform that action at this time.