New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dev-master for framework instead of tagged release #24

Merged
merged 1 commit into from Sep 12, 2018

Conversation

3 participants
@schlessera
Copy link
Member

schlessera commented Sep 12, 2018

@schlessera schlessera added this to the 2.1.0 milestone Sep 12, 2018

@schlessera schlessera added the bug label Sep 12, 2018

@schlessera schlessera merged commit 7fea088 into master Sep 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the 4940-use-latest-revision-of-framework branch Sep 12, 2018

@wojsmol wojsmol referenced this pull request Sep 12, 2018

Merged

Remove .behat-progress.log #25

/Users/alain/dev/newcli/wp-cli-bundle/features/cli.feature:31
/Users/alain/dev/newcli/wp-cli-bundle/features/cli.feature:74
/Users/alain/dev/newcli/wp-cli-bundle/features/cli.feature:103
/Users/alain/dev/newcli/wp-cli-bundle/features/cli.feature:138

This comment has been minimized.

@danielbachhuber

danielbachhuber Sep 12, 2018

Member

@schlessera Was this meant to be committed?

This comment has been minimized.

@wojsmol

wojsmol Sep 13, 2018

Contributor

@danielbachhuber IMHO this is committed by mistake - see my PR #25

@danielbachhuber

This comment has been minimized.

Copy link
Member

danielbachhuber commented Sep 12, 2018

@schlessera Should switching back to the stable release be documented in the release checklist?

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Sep 13, 2018

@danielbachhuber I don't think it is needed. The release will pull in the latest master from wp-cli/wp-cli, and at that moment in time, dev-master and the tagged release should point to the exact same revision.

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Sep 13, 2018

Regarding the .behat-progress.log, I think *.log should be added to all `.gitignore files to avoid this in the future.

@danielbachhuber

This comment has been minimized.

Copy link
Member

danielbachhuber commented Sep 13, 2018

The release will pull in the latest master from wp-cli/wp-cli, and at that moment in time, dev-master and the tagged release should point to the exact same revision.

@schlessera But the tagged version of wp-cli/wp-cli-bundle would then point to dev-master instead of a reproducible tag?

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Sep 13, 2018

@danielbachhuber You're right, thinking about it some more, it does indeed matter outside of Phar files. I'll add a corresponding check to the check list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment