New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move PHPUnit tests for `behat-tags.php` over #3

Merged
merged 7 commits into from Jul 22, 2018

Conversation

2 participants
@miya0001
Member

miya0001 commented Jul 20, 2018

Related: #1

miya0001 added some commits Jul 20, 2018

@miya0001

This comment has been minimized.

Member

miya0001 commented Jul 20, 2018

It is loading the behat-tags.php from wp-cli/wp-cli in vendor.
https://github.com/wp-cli/wp-cli-tests/pull/3/files#diff-5f62f4e43618da84371edc6a4461e647R73

@schlessera

It should load the utils/behat-tags.php from this package (wp-cli/wp-cli-tests).

@miya0001

This comment has been minimized.

Member

miya0001 commented Jul 20, 2018

I did.

miya0001 and others added some commits Jul 20, 2018

@schlessera schlessera merged commit cea9921 into master Jul 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the patch-1 branch Jul 22, 2018

@schlessera

This comment has been minimized.

Member

schlessera commented Jul 22, 2018

Thanks for the pull-request, @miya0001 !

I've modified the main php-composter/php-composter library to make it compatible with PHP 5.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment