Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Romanian language #329

Merged
merged 3 commits into from Jun 25, 2019

Conversation

@vladutilie
Copy link
Contributor

commented May 15, 2019

Hi,

I've translated the website in Romanian language, following the How to translate section.

Best regards,
Vlad

@schlessera

This comment has been minimized.

Copy link
Member

commented May 17, 2019

Thanks for the awesome work, @vladutilie!

One thing: You shouldn't translate the example code or app output. Translating the output of WP-CLI gives users the impression that there is a translated version of WP-CLI. Translating the source code will actually break things. For example, you've translated ## OPTIONS and ## EXAMPLES. These are being parsed by WP-CLI to generate the synopsis and the live help. If people use such a translated docblock, this will not work as expected.

@vladutilie

This comment has been minimized.

Copy link
Contributor Author

commented May 17, 2019

Hi @schlessera,

Thank you for your feedback. I've fixed the translation, now should be fine.

Best regards,
Vlad

@schlessera schlessera added this to the 2.3.0 milestone May 29, 2019

@schlessera
Copy link
Member

left a comment

Looks good to me, for what I can tell.

Only one minor case change, and we're good to merge this.

_config.yml Outdated Show resolved Hide resolved
Update _config.yml
Change language label.
Thanks!

Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>

@schlessera schlessera merged commit f3caaaf into wp-cli:master Jun 25, 2019

@schlessera

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

Thanks for the PR, @vladutilie !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.