Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove composer.lock from git. #4717

Closed
gitlost opened this Issue Mar 2, 2018 · 3 comments

Comments

3 participants
@gitlost
Copy link
Contributor

commented Mar 2, 2018

For discussion.

Having composer.lock in git doesn't suit our development setup and should be removed. I can't see what value it adds, and removing it would for instance avoid the need to update Composer dependencies via the make-coffee bot, and also be one less thing to worry about generally.

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Mar 5, 2018

Previously #2280

Applications should commit composer.lock to the repository. The ensures that future builds of old tags produce predictable results. See the Composer documentation on the composer.lock files.

@schlessera

This comment has been minimized.

Copy link
Member

commented Mar 5, 2018

The make-coffee bot basically ensures that our tests are run with every single new version of our dependencies.

Removing the composer.lock file is tempting, as it often causes frustration, but you'll only replace immediate errors and some manual fiddling with hard-to-debug random errors that get introduced without our knowledge.

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Mar 8, 2018

Also worth noting wp-make-coffee was broken for a while (#4711). This is why our dependencies weren't auto-updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.