New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-CLI v1.5.1 release checklist #4766

Closed
danielbachhuber opened this Issue Apr 10, 2018 · 8 comments

Comments

3 participants
@danielbachhuber
Member

danielbachhuber commented Apr 10, 2018

There are several bugs worth bundling into a v1.5.1 release:

@danielbachhuber danielbachhuber added this to the 1.5.1 milestone Apr 10, 2018

@danielbachhuber

This comment has been minimized.

Member

danielbachhuber commented Apr 23, 2018

@schlessera

This comment has been minimized.

Member

schlessera commented Apr 23, 2018

@danielbachhuber:
What I didn't yet do is update the handbook, as I'm not sure how this can be done to only cover 1.5.1.

Other than that, everything should be taken care of already.

@tianon

This comment has been minimized.

tianon commented Apr 23, 2018

Sorry if this isn't an appropriate place to ask (happy to re-file elsewhere), but was it intentional for 1.5.1 to not include wp-cli-1.5.1.phar.gpg?

(Seems to still be included in https://make.wordpress.org/cli/handbook/release-checklist/#updating-the-phar-build, and #4647 / #4600 seems to imply it was not intentionally removed and that perhaps might be expanded to also include a detached .asc signature? 🙏)

❤️

@danielbachhuber

This comment has been minimized.

Member

danielbachhuber commented Apr 23, 2018

What I didn't yet do is update the handbook, as I'm not sure how this can be done to only cover 1.5.1.

I'm not sure I follow. Can you clarify?

Other than that, everything should be taken care of already.

I still see:

@danielbachhuber

This comment has been minimized.

Member

danielbachhuber commented Apr 23, 2018

Sorry if this isn't an appropriate place to ask (happy to re-file elsewhere), but was it intentional for 1.5.1 to not include wp-cli-1.5.1.phar.gpg?

Sorry about that. I've signed and uploaded.

@schlessera

This comment has been minimized.

Member

schlessera commented Apr 24, 2018

@danielbachhuber:
Oh, I assumed the Debian and RPM builds would be triggered automatically. I'll go through your list.

@danielbachhuber

This comment has been minimized.

Member

danielbachhuber commented May 8, 2018

@schlessera Is there a reason this issue is still open?

@schlessera

This comment has been minimized.

Member

schlessera commented May 8, 2018

@danielbachhuber: Yes, the RPM & DEB builds haven't been completed yet. I had trouble with Travis last time I wanted to do that, and went down a rabbit hole (trouble which is still not resolved, unfortunately).

I'll try triggering the builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment