Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check update file response status #2368

Merged
merged 1 commit into from Jan 11, 2016

Conversation

@hinaloe
Copy link
Contributor

commented Jan 11, 2016

Check update file download response status.

Now, when I try to update version which not already exist like 4.4.1-ja (that is it now), that return 404 and no content, but wp-cli try to unzip null file, and throw PCLZIP_ERR_BAD_FORMAT (-10) : Unable to find End of Central Dir Record signature.
It should check is response succeed.

@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Jan 11, 2016

Thanks!

danielbachhuber added a commit that referenced this pull request Jan 11, 2016

@danielbachhuber danielbachhuber merged commit 6189987 into wp-cli:master Jan 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@hinaloe hinaloe deleted the hinaloe:update-check-response-status branch Jan 28, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.