Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of `wp user list --format=count` #2370

Merged
merged 1 commit into from Jan 11, 2016

Conversation

@danielbachhuber
Copy link
Member

commented Jan 11, 2016

  • Only fetch user IDs, to avoid join with user meta table.
  • Skip unnecessary SQL_CALC_FOUND_ROWS

Fixes #2369

Improve performance of `wp user list --format=count`
* Only fetch user IDs, to avoid join with user meta table.
* Skip unnecessary `SQL_CALC_FOUND_ROWS`

@danielbachhuber danielbachhuber added this to the 0.23.0 milestone Jan 11, 2016

@szepeviktor

This comment has been minimized.

Copy link
Contributor

commented on bb8c85e Jan 11, 2016

@danielbachhuber Thank you. It's faster only by reading the code.
So user meta slows it down.
Thank you!

This comment has been minimized.

Copy link
Member Author

replied Jan 11, 2016

@szepeviktor Can you test against the same site so we know how much of a performance increase it is?

danielbachhuber added a commit that referenced this pull request Jan 11, 2016
Merge pull request #2370 from wp-cli/2369-list-user-perf
Improve performance of `wp user list --format=count`

@danielbachhuber danielbachhuber merged commit dc9e746 into master Jan 11, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the 2369-list-user-perf branch Jan 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.