Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't `exit` on premature success for `wp theme activate` #2412

Merged
merged 1 commit into from Jan 26, 2016

Conversation

@danielbachhuber
Copy link
Member

commented Jan 25, 2016

This can kill other scripts calling the method directly. return is
fine for our needs to stop command execution.

Fixes #2411

Don't `exit` on premature success for `wp theme activate`
This can kill other scripts calling the method directly. `return` is
fine for our needs to stop command execution.

@danielbachhuber danielbachhuber added this to the 0.23.0 milestone Jan 25, 2016

danielbachhuber added a commit that referenced this pull request Jan 26, 2016
Merge pull request #2412 from wp-cli/2411-return-success
Don't `exit` on premature success for `wp theme activate`

@danielbachhuber danielbachhuber merged commit 669649e into master Jan 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the 2411-return-success branch Jan 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.