Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `wp server` when php binary contains spaces #2422

Merged
merged 1 commit into from Jan 30, 2016

Conversation

@za-creature
Copy link
Contributor

commented Jan 29, 2016

Ran this on windows:

B:\Archpaper>vendor\bin\wp server --port=4900 --path=build
'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

While fixing, ran into a different bug in PHP (it seems to be windows-specific, but I can't confirm as all my linux php binaries reside in folders without spaces), so I added a workaround for that as well.

This is what I get after applying the fix:

B:\Archpaper>vendor\bin\wp server --port=4900 --path=build
PHP 7.0.1 Development Server started at Fri Jan 29 22:46:00 2016
Listening on http://localhost:4900
Document root is B:\Archpaper\build
Press Ctrl-C to quit.
Radu Dan
@danielbachhuber

This comment has been minimized.

Copy link
Member

commented Jan 30, 2016

Hey @za-creature, thanks for the PR!

danielbachhuber added a commit that referenced this pull request Jan 30, 2016
Merge pull request #2422 from za-creature/patch-1
Fix `wp server` when php binary contains spaces

@danielbachhuber danielbachhuber merged commit d0e5583 into wp-cli:master Jan 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.