Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more robust failed download checking in `wp cli update` #2488

Merged
merged 1 commit into from Feb 19, 2016

Conversation

@danielbachhuber
Copy link
Member

commented Feb 19, 2016

Because php file.xml returns exit code 0, we need to run a command
where only WP-CLI will return the string we expect.

Fixes #2483

Use more robust failed download checking in `wp cli update`
Because `php file.xml` returns exit code `0`, we need to run a command
where only WP-CLI will return the string we expect.
@danielbachhuber

This comment has been minimized.

Copy link
Member Author

commented Feb 19, 2016

Because @github-api is skipped on Travis, I ran features/cli.feature locally and all tests pass.

danielbachhuber added a commit that referenced this pull request Feb 19, 2016
Merge pull request #2488 from wp-cli/2483-durable-phar-check
Use more robust failed download checking in `wp cli update`

@danielbachhuber danielbachhuber merged commit cd32338 into master Feb 19, 2016

@danielbachhuber danielbachhuber deleted the 2483-durable-phar-check branch Feb 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.