Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run help early for `wp core` commands used when core isn't yet installed #2497

Merged
merged 1 commit into from Feb 21, 2016

Conversation

@danielbachhuber
Copy link
Member

commented Feb 21, 2016

While it would be more ideal to run help early always when core isn't
installed, we are unable to easily inspect the database for blog tables.

This change permits wp help core install to be run when
wp-config.php is created, but the database isn't yet configured.
Previously, the user would see a "Database not created" error.

Fixes #2191

Run help early for `wp core` commands used when core isn't yet installed
While it would be more ideal to run help early _always_ when core isn't
installed, we are unable to easily inspect the database for blog tables.

This change permits `wp help core install` to be run when
`wp-config.php` is created, but the database isn't yet configured.

@danielbachhuber danielbachhuber modified the milestone: 0.23.0 Feb 21, 2016

danielbachhuber added a commit that referenced this pull request Feb 21, 2016
Merge pull request #2497 from wp-cli/2191-help-early-core
Run help early for `wp core` commands used when core isn't yet installed

@danielbachhuber danielbachhuber merged commit 06ab31a into master Feb 21, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the 2191-help-early-core branch Feb 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.