Use wp-settings.php instead of wp-settings-cli.php for >=WP4.6
#3031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maintaining a fork isn't a ton of fun.
Because `wp-settings.php` doesn't globalize `$wpdb` itself, calling `wp-settings.php` inside of a class method means that `wp-includes/ms-settings.php` (which uses `$wpdb` but doesn't globalize it) will break unexpectedly. This problem was obscured originally because WP-CLI globalizes $wpdb, see b376153
|
Do you want to merge this and then have me bump the version or the other way around? |
Although the approach I've taken (using a lower version number) is imprecise, I think it works fine for our needs. Developers running trunk should be updating trunk regularly anyway. In short, no version bump needed in this particular case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintaining a fork isn't a ton of fun.
Fixes #2278